-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rime-ls: init at 0.4.0 #351508
Merged
Merged
rime-ls: init at 0.4.0 #351508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
This PR adds a new package
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
10.rebuild-linux: 1
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
and removed
10.rebuild-darwin: 1
10.rebuild-darwin: 1-10
labels
Oct 26, 2024
Vonfry
reviewed
Oct 27, 2024
sikmir
reviewed
Oct 27, 2024
sikmir
reviewed
Oct 27, 2024
sikmir
reviewed
Oct 27, 2024
Please use rebase to squash commits. |
Not sure if I've made it correctly upstream :( |
Vonfry
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
cc @NickCao |
wegank
added
the
12.approvals: 1
This PR was reviewed and approved by one reputable person
label
Nov 6, 2024
NickCao
reviewed
Nov 8, 2024
Remove pkg-config as is unused. |
NickCao
reviewed
Nov 9, 2024
wegank
removed
the
12.approvals: 1
This PR was reviewed and approved by one reputable person
label
Nov 10, 2024
definfo
force-pushed
the
init-rime-ls
branch
from
November 11, 2024 04:39
86daea4
to
cc4616a
Compare
Aleksanaa
reviewed
Nov 23, 2024
definfo
force-pushed
the
init-rime-ls
branch
2 times, most recently
from
November 24, 2024 07:17
9f96a55
to
f479241
Compare
NickCao
reviewed
Nov 24, 2024
NOTE: Currently rime-data is only used to pass checkPhase. Users may need to set RIME_DATA_DIR and configure editors themselves.
definfo
force-pushed
the
init-rime-ls
branch
from
November 25, 2024 15:50
f479241
to
f8d40e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
8.has: package (new)
This PR adds a new package
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 1-10
10.rebuild-linux: 1
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
See #345612
rime-ls is a language server for Rime input method engine.
Homepage: https://github.com/wlh320/rime-ls
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.